Sreekanth, > +static ssize_t > +version_fw_show(struct device *dev, struct device_attribute *attr, > + char *buf) > +{ > + struct Scsi_Host *shost = class_to_shost(dev); > + struct mpi3mr_ioc *mrioc = shost_priv(shost); > + struct mpi3mr_compimg_ver *fwver = &mrioc->facts.fw_ver; > + > + return snprintf(buf, PAGE_SIZE, "%d.%d.%d.%d.%05d-%05d\n", > + fwver->gen_major, fwver->gen_minor, fwver->ph_major, > + fwver->ph_minor, fwver->cust_id, fwver->build_num); > +} Please use sysfs_emit() for new code. -- Martin K. Petersen Oracle Linux Engineering