On Wed, May 04, 2022 at 11:01:38AM +0000, Benjamin Block wrote:
> On Tue, May 03, 2022 at 10:06:43PM +0200, Hannes Reinecke wrote:
> > + list_for_each_entry(port, &adapter->port_list, list) {
> > + struct fc_rport *rport = port->rport;
>
> Like Steffen said in the other review, this may be NULL here, since
> `scpnt` can be from a different context, and there is no guarantees this
> is always assigned, if you iterate over all port of an adapter.
>
> So you want:
>
> if (!rport)
> continue;
That is probably wrong; see Steffen's comments w.r.t. waiting for them
to appear, instead of skipping them.
--
Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Systems
IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy
Vorsitz. AufsR.: Gregor Pillen / Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
