RE: [PATCH 1/4] scsi: ufs: Reduce the clock scaling latency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Wait at most 20 ms before rechecking the doorbells instead of waiting
> for a potentially long time between doorbell checks.
> 
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
Reviewed-by: Avri Altman <avri.altman@xxxxxxx>

Nit:
An upper bound of 20msec seems reasonable.
Maybe we should create some linkage to DOORBELL_CLR_TOUT_US?
> ---
>  drivers/scsi/ufs/ufshcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 2b4390a1106e..a3fecbb403d3 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1141,7 +1141,7 @@ static int ufshcd_wait_for_doorbell_clr(struct
> ufs_hba *hba,
>                 }
> 
>                 spin_unlock_irqrestore(hba->host->host_lock, flags);
> -               schedule();
> +               io_schedule_timeout(msecs_to_jiffies(20));
>                 if (ktime_to_us(ktime_sub(ktime_get(), start)) >
>                     wait_timeout_us) {
>                         timeout = true;




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux