On Mon, 2022-04-25 at 06:19 +0000, Avri Altman wrote: > > From: Bean Huo <beanhuo@xxxxxxxxxx> > > > > According to the documentation of the sysfs nodes rb_noti_cnt, > > rb_active_cnt > > and rb_inactive_cnt, they are all related to HPB recommendation in > > UPIU > > response packet. I don't know what 'rb' refers to, I think 'rcmd' > > (recommendation) should be the correct abbreviation. > rb stands for READ-BUFFER > Thanks. right. probably it is HPB READ BUFFER. I think based on the documentation,rcmd much makes sense, there is region inactive recommendation, it is no need to issue HPB read buffer. > > > > Change the sysfs documentation about these sysfs nodes to highlight > > what > > they mean under different HPB control modes. > > > > Signed-off-by: Bean Huo <beanhuo@xxxxxxxxxx> > I don't think it is allowed to change the kernel's ABI. > I don't know where this limitation is stated, I see a lot of ABI change patches on the mailing list. Also, I didn't change its original meaning, I added a new node meaning to make it clearer. According to the documentation on these nodes, they should be used in HPB host control mode, right? Otherwise, we should add a new note for HPB host control mode. Considering we already have these nodes, we don't need to change the HPB host control mode code just by changing the ABI to have the HPB host control mode reuse them. Here are my thoughts on change. Please consider my changes again. Kind regards, Bean > Thanks, > Avri
