On 4/5/22 08:15, Borislav Petkov wrote: > From: Borislav Petkov <bp@xxxxxxx> > > Fix > > drivers/scsi/aacraid/commsup.c: In function ‘aac_handle_sa_aif’: > drivers/scsi/aacraid/commsup.c:1983:2: error: case label does not reduce to an integer constant > case SA_AIF_BPCFG_CHANGE: > ^~~~ > > See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@xxxxxxx for the gory > details as to why it triggers with older gccs only. > > Signed-off-by: Borislav Petkov <bp@xxxxxxx> > Cc: Adaptec OEM Raid Solutions <aacraid@xxxxxxxxxxxxx> > Cc: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx> > Cc: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx> > Cc: linux-scsi@xxxxxxxxxxxxxxx Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Thanks. > --- > drivers/scsi/aacraid/aacraid.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h > index f849e7c9d428..5e115e8b2ba4 100644 > --- a/drivers/scsi/aacraid/aacraid.h > +++ b/drivers/scsi/aacraid/aacraid.h > @@ -121,7 +121,7 @@ enum { > #define SA_AIF_PDEV_CHANGE (1<<4) > #define SA_AIF_LDEV_CHANGE (1<<5) > #define SA_AIF_BPSTAT_CHANGE (1<<30) > -#define SA_AIF_BPCFG_CHANGE (1<<31) > +#define SA_AIF_BPCFG_CHANGE (1U<<31) > > #define HBA_MAX_SG_EMBEDDED 28 > #define HBA_MAX_SG_SEPARATE 90 -- ~Randy
