> > On 4/23/22 07:24, jin young choi wrote: > > >>> +static DEVICE_ATTR_RW(wb_flush_on); > >> Maybe wb_flush_enable ? > >> > > 'wb_on' sysfs already existed. So I named it in the same format (_on) > > I'll change both. (_on -> _enable) > > sysfs attributes constitute an ABI. Breaking the user space ABI is not > allowed. Hence, renaming existing sysfs attributes is not an option. > > Thanks, > > Bart. I got it. Applied to v2 patch. I sent a mail from Google Web, but the mailing list was messed up with a tab problem. (Changed to git send-email) I'll be careful. Thanks, Jinyoung.