Re: [PATCH v5 1/8] mpi3mr: add BSG device support

[kernel test robot <lkp@xxxxxxxxx>]

Hi Sumit,

I love your patch! Perhaps something to improve:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on jejb-scsi/for-next hch-configfs/for-next linus/master v5.18-rc3 next-20220422]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Sumit-Saxena/mpi3mr-add-BSG-interface-support-for-controller-management/20220422-201527
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: alpha-randconfig-r033-20220422 (https://download.01.org/0day-ci/archive/20220423/202204230118.pTp3NoQc-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/a45cf34a6056cbcfd60079926a424e2ca56021aa
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sumit-Saxena/mpi3mr-add-BSG-interface-support-for-controller-management/20220422-201527
        git checkout a45cf34a6056cbcfd60079926a424e2ca56021aa
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/scsi/mpi3mr/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/scsi/mpi3mr/mpi3mr_app.c:21:5: warning: no previous prototype for 'mpi3mr_bsg_request' [-Wmissing-prototypes]
      21 | int mpi3mr_bsg_request(struct bsg_job *job)
         |     ^~~~~~~~~~~~~~~~~~
>> drivers/scsi/mpi3mr/mpi3mr_app.c:55:6: warning: no previous prototype for 'mpi3mr_bsg_node_release' [-Wmissing-prototypes]
      55 | void mpi3mr_bsg_node_release(struct device *dev)
         |      ^~~~~~~~~~~~~~~~~~~~~~~


vim +/mpi3mr_bsg_request +21 drivers/scsi/mpi3mr/mpi3mr_app.c

    12	
    13	/**
    14	 * mpi3mr_bsg_request - bsg request entry point
    15	 * @job: BSG job reference
    16	 *
    17	 * This is driver's entry point for bsg requests
    18	 *
    19	 * Return: 0 on success and proper error codes on failure
    20	 */
  > 21	int mpi3mr_bsg_request(struct bsg_job *job)
    22	{
    23		return 0;
    24	}
    25	
    26	/**
    27	 * mpi3mr_bsg_exit - de-registration from bsg layer
    28	 *
    29	 * This will be called during driver unload and all
    30	 * bsg resources allocated during load will be freed.
    31	 *
    32	 * Return:Nothing
    33	 */
    34	void mpi3mr_bsg_exit(struct mpi3mr_ioc *mrioc)
    35	{
    36		if (!mrioc->bsg_queue)
    37			return;
    38	
    39		bsg_remove_queue(mrioc->bsg_queue);
    40		mrioc->bsg_queue = NULL;
    41	
    42		device_del(mrioc->bsg_dev);
    43		put_device(mrioc->bsg_dev);
    44		kfree(mrioc->bsg_dev);
    45	}
    46	
    47	/**
    48	 * mpi3mr_bsg_node_release -release bsg device node
    49	 * @dev: bsg device node
    50	 *
    51	 * decrements bsg dev reference count
    52	 *
    53	 * Return:Nothing
    54	 */
  > 55	void mpi3mr_bsg_node_release(struct device *dev)
    56	{
    57		put_device(dev);
    58	}
    59	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp