On Thu, 2022-04-14 at 12:49 +0800, Po-Wen Kao wrote: > Hi Bean, > > The general idea looks good. > > As ufshpb_issue_umap_all_req in ufshpb_state_toggle won't actually > runs > at cold boot probe due to the fact that sdev are not present yet, > this > should avoid sending HPB command before UAC being cleared while keeps > HPB mapping clean when rest flow occurs. > > Just a concern, shouldn't ufshpb_issue_umap_all_req be send for each > sdev's corresponding hpb? > Hi Po Wen, I replied in another email that setting the flag resets all active regions in the device, which is a more efficient way, I have submitted a fix for HPB device mode, your review and testing are welcome. Kind regards, Bean > Looking forward to your further fixes. > >