On Tue, Apr 12, 2022 at 11:18:31AM -0700, Bart Van Assche wrote:
> Use get_unaligned_be16(...) instead of the equivalent but harder to read
> be16_to_cpup((__be16 *)...).
>
> Reviewed-by: Bean Huo <beanhuo@xxxxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index d4ef31e1a409..3ec26c9eb1be 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -7334,7 +7334,7 @@ static u32 ufshcd_get_max_icc_level(int sup_curr_uA, u32 start_scan, char *buff)
> u16 unit;
>
> for (i = start_scan; i >= 0; i--) {
> - data = be16_to_cpup((__be16 *)&buff[2 * i]);
> + data = get_unaligned_be16(&buff[2 * i]);
This is not "equivalent". get_unaligned_be16() works on unaligned values
whereas be16_to_cpup() assumes a naturally aligned value. This patch might
still be the right thing to do, but the explanation is not correct.
- Eric
