Bart, We can submit another patchset where we will move only structures which are used both by applications and drivers into the include/uapi and keep the remaining ones which are not used in the app into the older mpi3mr/mpi folder. However, I have a generic question on why we need to move the headers into uapi because the driver provides the transfer mechanism already in the uapi through app.h and the information transferred in through that is blob from the driver perspective and that goes to the controller directly and processed by the controller, only for specific cases like NVMe encapsulated command, to set up the DMA address the driver parse through the command. Wouldn't it make sense to keep all of the controller/firmware related structures along with the driver and expose only the transport mechanism in the uapi? Thanks Sathya On Fri, Apr 8, 2022 at 8:37 AM Bart Van Assche <bvanassche@xxxxxxx> wrote: > > On 4/7/22 22:13, Christoph Hellwig wrote: > > On Thu, Apr 07, 2022 at 03:29:08PM -0400, Sumit Saxena wrote: > >> MPI headers are used by user space applications so > >> it makes sense to move them to uapi/scsi/mpi3mr. > > > > I think this is a horrible idea. These headers are a huge and a bit of > > a mess, and no we need to provide uapi guarantees for them. > > Hi Christoph, > > Although I agree with the above: my understanding is that this patch > series adds a new NVMe pass-through mechanism but without adding the > necessary declarations under include/uapi. That is why I asked recently > to move the necessary declarations into the include/uapi directory. > > Bart. -- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
