On 4/6/22 16:12, John Garry wrote:
On 06/04/2022 02:39, Damien Le Moal wrote:
On 4/4/22 23:53, John Garry wrote:
For attaining a qc tag for a SAS host we need to allocate a bit in
ata_port.sas_tag_allocated bitmap.
However we already have a unique tag per device in range
[0, ATA_MAX_QUEUE) in the scsi cmnd budget token, so just use that
instead.
The valid range is [0, ATA_MAX_QUEUE - 1]. Tag ATA_MAX_QUEUE is
ATA_TAG_INTERNAL which is never allocated as a valid device tag but
used directly in ata_exec_internal().
But that is what I have in [0, ATA_MAX_QUEUE), which is same as [0,
ATA_MAX_QUEUE - 1].
Oh ! I missed the ")" !
I would prefer an explicit [0, ATA_MAX_QUEUE - 1] to be clear :)
Thanks,
john
--
Damien Le Moal
Western Digital Research
