On 4/1/22 23:59, Avri Altman wrote:
Commit 5b44a07b6bb2 ("scsi: ufs: Remove pre-defined initial voltage values of device power") removed the code that uses the UFS_VREG_VCC* constants and also the code that sets the min_uV and max_uV member variables. Hence also remove these constants and that member variable. Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>Looks fine to me, but better get an ack from Stanley, because he specifically wrote in his commit log: "... Note that we keep struct ufs_vreg unchanged. This allows vendors to configure proper min_uV and max_uV of any regulators to make regulator_set_voltage() works during regulator toggling flow in the future. Without specific vendor configurations, min_uV and max_uV will be NULL by default and UFS core driver will enable or disable the regulator only without adjusting its voltage. ..."
(+Stanley) Hi Stanley, Can you take a look at this patch? Thanks, Bart.
