On Tue, Jun 19 2007, Boaz Harrosh wrote: > From 6f4641911701cbdbe01516305b682012d8c6982a Mon Sep 17 00:00:00 2001 > Date: Tue, 19 Jun 2007 18:54:54 +0300 > > I have unearthed very old bugs in stale drivers that still > used request->cmd as a READ|WRITE int. > This patch is maybe a proof that these drivers have not been > used for a long time. Should they be removed completely? If you look at most of the code, it's inside ifdef debug statements or comments most of them. So I don't think you can base any removal suggestion on that. The patch itself looks fine though, if you send one that isn't mangled I'll apply it to the 2.6.23 branch. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html