Kristian Høgsberg wrote:
> On 6/18/07, Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> wrote:
...
>> + scsi_remove_host(host);
>> sbp2_send_management_orb(sd->unit, sd->node_id, sd->generation,
>> SBP2_LOGOUT_REQUEST, sd->login_id, NULL);
>> -
>> - scsi_remove_host(host);
>> fw_core_remove_address_handler(&sd->address_handler);
>> fw_notify("removed sbp2 unit %s\n", sd->unit->device.bus_id);
>> put_device(&sd->unit->device);
>
> This change looks right, but I just seem to remember I changed those
> lines around before... But I can't think of why your change shouldn't
> be correct, so let's just do that.
>
> Signed-off-by: Kristian Høgsberg <krh@xxxxxxxxxx>
I just dug around with qgit. The logout has always been before removal
of the shost. Maybe it was different before you submitted? BTW the old
sbp2 driver logged out before host removal too, until Linux 2.6.13
inclusive.
--
Stefan Richter
-=====-=-=== -==- =--=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
