On 3/17/22 10:01 AM, Wenchao Hao wrote: > iscsi_cls_conn is alloced by kzalloc(), the whole iscsi_cls_conn is > zero filled already including the dd_data. So it is unnecessary to > call memset again. > > Signed-off-by: Wenchao Hao <haowenchao@xxxxxxxxxx> > Reviewed-by: Wu Bo <wubo40@xxxxxxxxxx> > Reviewed-by: Lee Duncan <lduncan@xxxxxxxx> > --- > drivers/scsi/libiscsi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c > index d09926e6c8a8..cf4211c6500d 100644 > --- a/drivers/scsi/libiscsi.c > +++ b/drivers/scsi/libiscsi.c > @@ -3045,7 +3045,6 @@ iscsi_conn_setup(struct iscsi_cls_session *cls_session, int dd_size, > if (!cls_conn) > return NULL; > conn = cls_conn->dd_data; > - memset(conn, 0, sizeof(*conn) + dd_size); > > conn->dd_data = cls_conn->dd_data + sizeof(*conn); > conn->session = session; Reviewed-by: Mike Christie <michael.christie@xxxxxxxxxx>
