On Mon, Mar 14, 2022 at 04:03:21PM +0100, Lukas Bulwahn wrote: > Commit 01d0c698536f ("sr: implement ->free_disk to simplify refcounting") > refactored sr_block_open(), initialized one variable with a duplicate > assignment (probably an unintended copy & paste duplication) and turned one > error case into an early return, which makes the initialization of the > return variable needless. > > So, simplify the local variable initialization in sr_block_open() to make > the code a bit more clear. > > No functional change. No change in resulting object code. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> > --- > Christoph, please ack. > > Jens, please pick this minor clean-up on your -next branch on top of the > commit above. Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>