Re: [PATCH 09/13] qla2xxx: reduce false trigger to login

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Mar 8, 2022, at 12:20 AM, Nilesh Javali <njavali@xxxxxxxxxxx> wrote:
> 
> From: Quinn Tran <qutran@xxxxxxxxxxx>
> 
> While a session is in the middle of a relogin,
> a late RSCN can be delivered from switch. RSCN trigger fabric
> scan where the scan logic can trigger another session login
> while a login is in progress.
> This patch reduce the extra trigger to prevent multiple login
> to the same session.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: bee8b84686c4 ("scsi: qla2xxx: Reduce redundant ADISC command for RSCNs")
> Signed-off-by: Quinn Tran <qutran@xxxxxxxxxxx>
> Signed-off-by: Nilesh Javali <njavali@xxxxxxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_init.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
> index 3c58a2911937..a53894444460 100644
> --- a/drivers/scsi/qla2xxx/qla_init.c
> +++ b/drivers/scsi/qla2xxx/qla_init.c
> @@ -1644,7 +1644,8 @@ int qla24xx_fcport_handle_login(struct scsi_qla_host *vha, fc_port_t *fcport)
> 	    fcport->login_gen, fcport->loop_id, fcport->scan_state,
> 	    fcport->fc4_type);
> 
> -	if (fcport->scan_state != QLA_FCPORT_FOUND)
> +	if (fcport->scan_state != QLA_FCPORT_FOUND ||
> +	    fcport->disc_state == DSC_DELETE_PEND)
> 		return 0;
> 
> 	if ((fcport->loop_id != FC_NO_LOOP_ID) &&
> @@ -1665,7 +1666,7 @@ int qla24xx_fcport_handle_login(struct scsi_qla_host *vha, fc_port_t *fcport)
> 	if (vha->host->active_mode == MODE_TARGET && !N2N_TOPO(vha->hw))
> 		return 0;
> 
> -	if (fcport->flags & FCF_ASYNC_SENT) {
> +	if (fcport->flags & (FCF_ASYNC_SENT | FCF_ASYNC_ACTIVE)) {
> 		set_bit(RELOGIN_NEEDED, &vha->dpc_flags);
> 		return 0;
> 	}
> -- 
> 2.19.0.rc0
> 

Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

--
Himanshu Madhani	 Oracle Linux Engineering





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux