On Mon, 28 Feb 2022 18:48:57 +0900, Damien Le Moal wrote: > Sparse throws a warning about context imbalance ("different lock > contexts for basic block") in sas_form_port() as it gets confused with > the fact that a port is locked within one of the 2 search loop and > unlocked afterward outside of the search loops once the phy is added to > the port. Since this code is not easy to follow, improve it by factoring > out the code adding the phy to the port once the port is locked into the > helper function sas_form_port_add_phy(). This helper can then be called > directly within the port search loops, avoiding confusion and clearing > the sparse warning. > > [...] Applied to 5.18/scsi-queue, thanks! [1/1] scsi: libsas: cleanup sas_form_port() https://git.kernel.org/mkp/scsi/c/32698c955295 -- Martin K. Petersen Oracle Linux Engineering