On 3/7/22 10:59 PM, Bart Van Assche wrote: > On 3/7/22 16:39, Mike Christie wrote: >> -static int iscsi_iser_task_xmit(struct iscsi_task *task) >> +static int iscsi_iser_task_xmit(struct iscsi_task *task, bool dontwait) > > Arguments with "not" in their name easily lead to double negations. Has it been considered to change "bool dontwait" into "bool may_sleep" and to inverse the argument passed to this and similar functions? Yeah, I'm not tied to any naming. I just copied the name from the network layer's MSG_DONTWAIT flag. I was going to suggest something with "block" in the name but I I saw in your other comment you might like something with sleep. may_sleep is fine with me. For the queuecommand related field, I'll do a sleep variant too.
