We found a NULL pointer dereference in iscsi_sw_tcp_conn_get_param(), the root reason is we did sysfs addition wrong. iscsi_create_conn() expose iscsi_cls_conn to sysfs while the related resources are not initialized. So we should delay the calling of device_add() until these resources has been initialized. This patchset solve this issue by changing iscsi_conn_setup() and works well for iscsi_tcp. Wenchao Hao (2): scsi: iscsi: Add helper functions to alloc and add iscsi_cls_conn scsi:libiscsi: Add iscsi_cls_conn to sysfs after been initialized drivers/scsi/libiscsi.c | 13 ++++- drivers/scsi/scsi_transport_iscsi.c | 85 +++++++++++++++++++++++------ include/scsi/scsi_transport_iscsi.h | 3 + 3 files changed, 83 insertions(+), 18 deletions(-) -- 2.32.0
