On 3/3/22 21:18, John Garry wrote: > This is a follow-on from the series to factor out the TMF code shared > between libsas LLDDs. > > The hisi_sas and pm8001 have an internal abort feature to abort pending > commands in the host controller, prior to being sent to the target. The > driver support implementation is naturally quite similar, so factor it > out. > > Again, testing and review would be appreciated. I ran my usual set of tests with fio and also libzbc tests to exercise the failure/abort path. No problems detected. All good to me. Feel free to add: Tested-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx> To your V2 with the cosmetic fixes. > > This is based on mkp-scsi 5.18 staging queue @ commit f2ddbbea7780 > > John Garry (4): > scsi: libsas: Add sas_execute_internal_abort_single() > scsi: libsas: Add sas_execute_internal_abort_dev() > scsi: pm8001: Use libsas internal abort support > scsi: hisi_sas: Use libsas internal abort support > > drivers/scsi/hisi_sas/hisi_sas.h | 8 +- > drivers/scsi/hisi_sas/hisi_sas_main.c | 453 +++++++++---------------- > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 11 +- > drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 18 +- > drivers/scsi/libsas/sas_scsi_host.c | 89 +++++ > drivers/scsi/pm8001/pm8001_hwi.c | 27 +- > drivers/scsi/pm8001/pm8001_hwi.h | 5 - > drivers/scsi/pm8001/pm8001_sas.c | 186 ++++------ > drivers/scsi/pm8001/pm8001_sas.h | 6 +- > drivers/scsi/pm8001/pm80xx_hwi.h | 5 - > include/scsi/libsas.h | 24 ++ > include/scsi/sas.h | 2 + > 12 files changed, 368 insertions(+), 466 deletions(-) > -- Damien Le Moal Western Digital Research
