Re: [PATCH 09/14] scsi: sd: Fix discard errors during revalidate

[Bart Van Assche <bvanassche@xxxxxxx>]

On 3/1/22 21:35, Martin K. Petersen wrote:
> +	if (mode == SD_LBP_DEFAULT)
> +		sdkp->provisioning_override = false;
> +	else
> +		sdkp->provisioning_override = true;

This can be changed into the following?

sdkp->provisioning_override = mode != SD_LBP_DEFAULT;

> +	if (mode == SD_LBP_DEFAULT && !sdkp->provisioning_override) {

Hmm ... is provisioning_override ever true for the SD_LBP_DEFAULT mode? If not, 
can "&& !sdkp->provisioning_override" be left out?

> +	bool		lblvpd;

Please add a comment that explains what lblvpd stands for.

Thanks,

Bart.