On 28/02/2022 15:54, Zheyu Ma wrote: > During the process of driver probing, the probe function should return < 0 > for failure, otherwise, the kernel will treat value >= 0 as success. "So set 'err' to the error value returned by dma_set_mask() in case of failure" Otherwise looks good to me, Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>