On 2/25/22 04:49, Bart Van Assche wrote:
> On 2/24/22 02:11, Damien Le Moal wrote:
>> diff --git a/drivers/scsi/mpt3sas/mpi/mpi2_init.h b/drivers/scsi/mpt3sas/mpi/mpi2_init.h
>> index 8f1b903fe0a9..80bcf7d83184 100644
>> --- a/drivers/scsi/mpt3sas/mpi/mpi2_init.h
>> +++ b/drivers/scsi/mpt3sas/mpi/mpi2_init.h
>> @@ -428,7 +428,7 @@ typedef struct _MPI2_SCSI_TASK_MANAGE_REQUEST {
>> U16 Reserved3; /*0x0A */
>> U8 LUN[8]; /*0x0C */
>> U32 Reserved4[7]; /*0x14 */
>> - U16 TaskMID; /*0x30 */
>> + __le16 TaskMID; /*0x30 */
>> U16 Reserved5; /*0x32 */
>> } MPI2_SCSI_TASK_MANAGE_REQUEST,
>> *PTR_MPI2_SCSI_TASK_MANAGE_REQUEST,
>
> Is this change necessary? From drivers/scsi/mpt3sas/mpi/mpi2_type.h:
>
> typedef __le16 U16;
Well, sparse seems to not catch that. Without the change, I get
warnings. Will check again.
>
> BTW, I think the U16 etc. typedefs should disappear.
I agree on that :)
>
> Thanks,
>
> Bart.
--
Damien Le Moal
Western Digital Research
