Hi Krzysztof >-----Original Message----- >From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxxxxx] >Sent: Tuesday, February 22, 2022 8:29 PM >To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; Avri Altman ><avri.altman@xxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof >Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>; Andy Gross ><agross@xxxxxxxxxx>; Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>; Wei >Xu <xuwei5@xxxxxxxxxxxxx>; Nishanth Menon <nm@xxxxxx>; Vignesh >Raghavendra <vigneshr@xxxxxx>; Tero Kristo <kristo@xxxxxxxxxx>; James E.J. >Bottomley <jejb@xxxxxxxxxxxxx>; Martin K. Petersen ><martin.petersen@xxxxxxxxxx>; Jan Kotas <jank@xxxxxxxxxxx>; Li Wei ><liwei213@xxxxxxxxxx>; Stanley Chu <stanley.chu@xxxxxxxxxxxx>; Yaniv >Gardi <ygardi@xxxxxxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx; >devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm- >msm@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung- >soc@xxxxxxxxxxxxxxx; linux-mediatek@xxxxxxxxxxxxxxxxxxx >Subject: [PATCH v2 09/15] scsi: ufs: deprecate 'freq-table-hz' property > >The 'freq-table-hz' is not correct in DT schema, because '-hz' suffix defines >uint32 type, not an array. Therefore deprecate 'freq-table-hz' >and use 'freq-table' instead. > May be once all the dts change migrate to using 'freq-table', just remove 'freq-table-hz' from driver. >Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> >--- > drivers/scsi/ufs/ufshcd-pltfrm.c | 21 +++++++++++++-------- > 1 file changed, 13 insertions(+), 8 deletions(-) > >diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c >index 87975d1a21c8..2b192477d158 100644 >--- a/drivers/scsi/ufs/ufshcd-pltfrm.c >+++ b/drivers/scsi/ufs/ufshcd-pltfrm.c >@@ -47,8 +47,9 @@ static int ufshcd_parse_clock_info(struct ufs_hba *hba) > if (cnt <= 0) > goto out; > >- if (!of_get_property(np, "freq-table-hz", &len)) { >- dev_info(dev, "freq-table-hz property not specified\n"); >+ if (!of_get_property(np, "freq-table", &len) || >+ !of_get_property(np, "freq-table-hz", &len)) { >+ dev_info(dev, "freq-table property not specified\n"); > goto out; > } > >@@ -57,7 +58,7 @@ static int ufshcd_parse_clock_info(struct ufs_hba *hba) > > sz = len / sizeof(*clkfreq); > if (sz != 2 * cnt) { >- dev_err(dev, "%s len mismatch\n", "freq-table-hz"); >+ dev_err(dev, "%s len mismatch\n", "freq-table"); > ret = -EINVAL; > goto out; > } >@@ -69,12 +70,16 @@ static int ufshcd_parse_clock_info(struct ufs_hba >*hba) > goto out; > } > >- ret = of_property_read_u32_array(np, "freq-table-hz", >+ ret = of_property_read_u32_array(np, "freq-table", > clkfreq, sz); > if (ret && (ret != -EINVAL)) { >- dev_err(dev, "%s: error reading array %d\n", >- "freq-table-hz", ret); >- return ret; >+ ret = of_property_read_u32_array(np, "freq-table-hz", >+ clkfreq, sz); >+ if (ret && (ret != -EINVAL)) { >+ dev_err(dev, "%s: error reading array %d\n", >+ "freq-table", ret); >+ return ret; >+ } > } > > for (i = 0; i < sz; i += 2) { >@@ -99,7 +104,7 @@ static int ufshcd_parse_clock_info(struct ufs_hba *hba) > > if (!strcmp(name, "ref_clk")) > clki->keep_link_active = true; >- dev_dbg(dev, "%s: min %u max %u name %s\n", "freq-table- >hz", >+ dev_dbg(dev, "%s: min %u max %u name %s\n", "freq-table", > clki->min_freq, clki->max_freq, clki->name); > list_add_tail(&clki->list, &hba->clk_list_head); > } >-- >2.32.0
