device_add already takes a reference on the parent, not need to take an extra one. Signed-off-by: Christoph Hellwig <hch@xxxxxx> --- drivers/scsi/sd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 4eaa5deafc3dc..041c21c9483f6 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -3503,7 +3503,7 @@ static int sd_probe(struct device *dev) } device_initialize(&sdkp->dev); - sdkp->dev.parent = get_device(dev); + sdkp->dev.parent = dev; sdkp->dev.class = &sd_disk_class; dev_set_name(&sdkp->dev, "%s", dev_name(dev)); @@ -3615,7 +3615,6 @@ static void scsi_disk_release(struct device *dev) struct scsi_disk *sdkp = to_scsi_disk(dev); ida_free(&sd_index_ida, sdkp->index); - put_device(&sdkp->device->sdev_gendev); sd_zbc_release_disk(sdkp); kfree(sdkp); } -- 2.30.2
