On Thu, Feb 17, 2022 at 2:30 PM Damien Le Moal
<damien.lemoal@xxxxxxxxxxxxxxxxxx> wrote:
>
> To detect if a command is NCQ, there is no need to test all possible NCQ
> command codes. Instead, use ata_is_ncq() to test the command protocol.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
Reviewed-by: Jack Wang <jinpu.wang@xxxxxxxxx>
> ---
> drivers/scsi/libsas/sas_ata.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
> index 50f779088b6e..fcfc8fd4b14f 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -181,14 +181,9 @@ static unsigned int sas_ata_qc_issue(struct ata_queued_cmd *qc)
> task->task_proto = SAS_PROTOCOL_STP;
> task->task_done = sas_ata_task_done;
>
> - if (qc->tf.command == ATA_CMD_FPDMA_WRITE ||
> - qc->tf.command == ATA_CMD_FPDMA_READ ||
> - qc->tf.command == ATA_CMD_FPDMA_RECV ||
> - qc->tf.command == ATA_CMD_FPDMA_SEND ||
> - qc->tf.command == ATA_CMD_NCQ_NON_DATA) {
> - /* Need to zero out the tag libata assigned us */
> + /* For NCQ commands, zero out the tag libata assigned us */
> + if (ata_is_ncq(qc->tf.protocol))
> qc->tf.nsect = 0;
> - }
>
> ata_tf_to_fis(&qc->tf, qc->dev->link->pmp, 1, (u8 *)&task->ata_task.fis);
> task->uldd_task = qc;
> --
> 2.34.1
>
