On Thu, Feb 17, 2022 at 2:30 PM Damien Le Moal
<damien.lemoal@xxxxxxxxxxxxxxxxxx> wrote:
>
> In mpi_set_phy_profile_req() and pm8001_set_phy_profile_single(), use
> cpu_to_le32() to initialize the ppc_phyid field of struct
> set_phy_profile_req. Furthermore, fix the definition of the reserved
> field of this structure to be an array of __le32, to match the use of
> cpu_to_le32() when assigning values. These changes remove several sparse
> type warnings.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
Reviewed-by: Jack Wang <jinpu.wang@xxxxxxxxx>
thx!
> ---
> drivers/scsi/pm8001/pm80xx_hwi.c | 12 +++++++-----
> drivers/scsi/pm8001/pm80xx_hwi.h | 2 +-
> 2 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index 1f3b01c70f24..60c305f987b5 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -4970,12 +4970,13 @@ static void mpi_set_phy_profile_req(struct pm8001_hba_info *pm8001_ha,
> pm8001_dbg(pm8001_ha, FAIL, "Invalid tag\n");
> circularQ = &pm8001_ha->inbnd_q_tbl[0];
> payload.tag = cpu_to_le32(tag);
> - payload.ppc_phyid = (((operation & 0xF) << 8) | (phyid & 0xFF));
> + payload.ppc_phyid =
> + cpu_to_le32(((operation & 0xF) << 8) | (phyid & 0xFF));
> pm8001_dbg(pm8001_ha, INIT,
> " phy profile command for phy %x ,length is %d\n",
> - payload.ppc_phyid, length);
> + le32_to_cpu(payload.ppc_phyid), length);
> for (i = length; i < (length + PHY_DWORD_LENGTH - 1); i++) {
> - payload.reserved[j] = cpu_to_le32(*((u32 *)buf + i));
> + payload.reserved[j] = cpu_to_le32(*((u32 *)buf + i));
> j++;
> }
> rc = pm8001_mpi_build_cmd(pm8001_ha, circularQ, opc, &payload,
> @@ -5015,8 +5016,9 @@ void pm8001_set_phy_profile_single(struct pm8001_hba_info *pm8001_ha,
> opc = OPC_INB_SET_PHY_PROFILE;
>
> payload.tag = cpu_to_le32(tag);
> - payload.ppc_phyid = (((SAS_PHY_ANALOG_SETTINGS_PAGE & 0xF) << 8)
> - | (phy & 0xFF));
> + payload.ppc_phyid =
> + cpu_to_le32(((SAS_PHY_ANALOG_SETTINGS_PAGE & 0xF) << 8)
> + | (phy & 0xFF));
>
> for (i = 0; i < length; i++)
> payload.reserved[i] = cpu_to_le32(*(buf + i));
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.h b/drivers/scsi/pm8001/pm80xx_hwi.h
> index c41ed039c92a..d66b49323d49 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.h
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.h
> @@ -972,7 +972,7 @@ struct dek_mgmt_req {
> struct set_phy_profile_req {
> __le32 tag;
> __le32 ppc_phyid;
> - u32 reserved[29];
> + __le32 reserved[29];
> } __attribute__((packed, aligned(4)));
>
> /**
> --
> 2.34.1
>
