On 2/15/22 04:00, Bart Van Assche wrote:
On 2/14/22 03:55, Hannes Reinecke wrote:
I had a closer look at the usage of SCp.ptr in the various FCoE
drivers, and it turns out that all have their own private use of SCp.ptr.
The only 'generic' use of SCp.ptr (where it points to 'struct
libfc_cmd_priv') is in fcoe/fcoe.c.
For the others (bnx2fc, qedf, and fnic) they point to their own,
private, data structure, and there's no overlap with libfc itself.
So no need to have a combined structure, and each driver should use
their own data structure only.
(IE bnx2fc_priv should just have the 'bnx2fc_cmd' pointer).
How about splitting this patch into the three patches below?
Thanks,
Bart.
[ .. ]
Yes, this is what I had in mind.
Although you can kill the 'status' field for bnx2fc; it's only ever set
and never read.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
