On 14/02/2022 02:17, Damien Le Moal wrote:
This first part of this series (patches 1 to 24) fixes handling of NCQ
NON DATA commands in libsas and many bugs in the pm8001 driver.
The fixes for the pm8001 driver include:
* Suppression of all sparse warnings, fixing along the way many le32
handling bugs for big-endian architectures
* Fix handling of NCQ NON DATA commands
* Fix of tag values handling (0*is* a valid tag value)
* Fix many tag iand memory leaks in error path
* Fix NCQ error recovery (abort all task execution) that was causing a
crash
The second part of the series (patches 25 to 31) iadd a small cleanup of
libsas code and many simplifications of the pm8001 driver code.
With these fixes, libzbc test suite passes all test case. This test
suite was used with an SMR drive for testing because it generates many
NCQ NON DATA commands (for zone management commands) and also generates
many NCQ command errors to check ASC/ASCQ returned by the device. With
the test suite, the error recovery path was extensively exercised. The
same tests were also executed with a SAS SMR drives to exercise the
error path.
The patches are based on the 5.18/scsi-staging tree.
Hi Damien,
jfyi, I still see the hang with this series. I don't think that the tag
fixes were relevant unfortunately.
btw, how about add guys from get_maintainers.pl to lighten the review
workload (and we should have the official maintainer anyway)? There are
quite a few patches now...
Thanks,
John
