On 2/11/22 00:35, John Garry wrote: > On 10/02/2022 11:41, Damien Le Moal wrote: >> The first 3 patches fix a problem with libsas handling of NCQ NON DATA >> commands and simplify libsas code in a couple of places. >> The remaining patches are fixes for the pm8001 driver: >> * All sparse warnings are addressed, fixing along the way many le32 >> handling bugs for big-endian architectures >> * Fix handling of NCQ NON DATA commands >> * Fix NCQ error recovery (abort all task execution) that was causing a >> crash >> * Simplify the code in many places >> >> With these fixes, libzbc test suite passes all test case. This test >> suite was used with an SMR drive for testing because it generates many >> NCQ NON DATA commands (for zone management commands) and also generates >> many NCQ command errors to check ASC/ASCQ returned by the device. With >> the test suite, the error recovery path was extensively exercised. >> >> Note that without these patches, libzbc test suite result in the >> controller hanging, or in kernel crashes. > > Unfortunately I still see the hang on my arm64 system with this series :( That is unfortunate. Any particular command sequence triggering the hang ? Or is it random ? What workload are you running ? > > Thanks, > John -- Damien Le Moal Western Digital Research
