On 2/9/22 19:35, Bart Van Assche wrote:
On 2/9/22 00:11, Hannes Reinecke wrote:
On 2/8/22 18:24, Bart Van Assche wrote:
+static inline struct scsi_pointer *mac53c94_scsi_pointer(struct
scsi_cmnd *cmd)
+{
+ struct mac53c94_cmd_priv *mcmd = scsi_cmd_priv(cmd);
+
+ return &mcmd->scsi_pointer;
+}
+
#endif /* _MAC53C94_H */
Also here: Why not use 'struct scsi_pointer' directly as command payload?
To make it easier to add more private command data in the future. Do you
perhaps want me to use struct scsi_pointer directly?
As indicated in my previous comment: in principle, yes.
But this driver is using 'host_scribble', too, which should be moved
into the command payload, too.
So this patch is fine.
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
