Re: [PATCH v2 20/44] hptiop: Stop using the SCSI pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/9/22 19:24, Bart Van Assche wrote:
On 2/8/22 23:57, Hannes Reinecke wrote:
On 2/8/22 18:24, Bart Van Assche wrote:
-struct hpt_scsi_pointer {
+struct hpt_cmd_priv {

Why not keep the name? You have been using 'struct scsi_pointer' with all the other drivers ...

I assume that "SCSI pointer" refers to a section in the SCSI II specification with the same title. The hptiop private data is not related to the SCSI II "SCSI pointer" section. Hence the renaming of this data structure.

Ah, right. Misread the patch.

Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke                Kernel Storage Architect
hare@xxxxxxx                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux