Re: [PATCH v2 22/44] iscsi: Stop using the SCSI pointer

[Bart Van Assche <bvanassche@xxxxxxx>]

On 2/9/22 15:37, Chris Leech wrote:
> On 2/8/22 9:24 AM, Bart Van Assche wrote:
> > --- a/drivers/scsi/qedi/qedi_fw.c
> > +++ b/drivers/scsi/qedi/qedi_fw.c
> > @@ -603,7 +603,7 @@ static void qedi_scsi_completion(struct qedi_ctx *qedi,
> >   		goto error;
> >   	}
> >   
> > -	if (!sc_cmd->SCp.ptr) {
> > +	if (!iscsi_cmd(sc_cmd)->task) {
> >   		QEDI_WARN(&qedi->dbg_ctx,
> >   			  "SCp.ptr is NULL, returned in another context.\n");
> >   		goto error;
> > diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscsi.c
> > index 282ecb4e39bb..8196f89f404e 100644
>
> Minor nit, but this warning should probably be changed as well.

Thanks, I will fix the reference to SCp.ptr.

Bart.