> On Feb 8, 2022, at 9:25 AM, Bart Van Assche <bvanassche@xxxxxxx> wrote:
>
> This patch fixes the following compiler warning:
>
> drivers/scsi/mvsas/mv_init.c: In function ‘mvs_pci_init’:
> drivers/scsi/mvsas/mv_init.c:497:30: warning: variable ‘mpi’ set but not used [-Wunused-but-set-variable]
> 497 | struct mvs_prv_info *mpi;
> | ^~~
>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> drivers/scsi/mvsas/mv_init.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
> index dcae2d4464f9..d82b3129119a 100644
> --- a/drivers/scsi/mvsas/mv_init.c
> +++ b/drivers/scsi/mvsas/mv_init.c
> @@ -494,7 +494,6 @@ static int mvs_pci_init(struct pci_dev *pdev, const struct pci_device_id *ent)
> {
> unsigned int rc, nhost = 0;
> struct mvs_info *mvi;
> - struct mvs_prv_info *mpi;
> irq_handler_t irq_handler = mvs_interrupt;
> struct Scsi_Host *shost = NULL;
> const struct mvs_chip_info *chip;
> @@ -559,10 +558,14 @@ static int mvs_pci_init(struct pci_dev *pdev, const struct pci_device_id *ent)
> }
> nhost++;
> } while (nhost < chip->n_host);
> - mpi = (struct mvs_prv_info *)(SHOST_TO_SAS_HA(shost)->lldd_ha);
> #ifdef CONFIG_SCSI_MVSAS_TASKLET
> + {
> + struct mvs_prv_info *mpi;
> +
> + mpi = (struct mvs_prv_info *)(SHOST_TO_SAS_HA(shost)->lldd_ha);
> tasklet_init(&(mpi->mv_tasklet), mvs_tasklet,
> (unsigned long)SHOST_TO_SAS_HA(shost));
> + }
> #endif
>
> mvs_post_sas_ha_init(shost, chip);
Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
--
Himanshu Madhani Oracle Linux Engineering
