> On Feb 8, 2022, at 9:24 AM, Bart Van Assche <bvanassche@xxxxxxx> wrote:
>
> Report both the command flags and command state instead of only the
> command state.
>
> Cc: Hiral Patel <hiralpat@xxxxxxxxx>
> Fixes: 4d7007b49d52 ("[SCSI] fnic: Fnic Trace Utility")
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> drivers/scsi/fnic/fnic_scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
> index 88c549f257db..549754245f7a 100644
> --- a/drivers/scsi/fnic/fnic_scsi.c
> +++ b/drivers/scsi/fnic/fnic_scsi.c
> @@ -604,7 +604,7 @@ static int fnic_queuecommand_lck(struct scsi_cmnd *sc)
>
> FNIC_TRACE(fnic_queuecommand, sc->device->host->host_no,
> tag, sc, io_req, sg_count, cmd_trace,
> - (((u64)CMD_FLAGS(sc) >> 32) | CMD_STATE(sc)));
> + (((u64)CMD_FLAGS(sc) << 32) | CMD_STATE(sc)));
>
> /* if only we issued IO, will we have the io lock */
> if (io_lock_acquired)
Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
--
Himanshu Madhani Oracle Linux Engineering
