Re: [PATCH v2 15/44] dc395x: Stop using the SCSI pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Feb 8, 2022, at 9:24 AM, Bart Van Assche <bvanassche@xxxxxxx> wrote:
> 
> Remove the code that sets SCSI pointer members since there is no code in
> this driver that reads these members.
> 
> Cc: Oliver Neukum <oneukum@xxxxxxxx>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> drivers/scsi/dc395x.c | 3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
> index c11916b8ae00..67a89715c863 100644
> --- a/drivers/scsi/dc395x.c
> +++ b/drivers/scsi/dc395x.c
> @@ -3314,9 +3314,6 @@ static void srb_done(struct AdapterCtlBlk *acb, struct DeviceCtlBlk *dcb,
> 
> 	/* Here is the info for Doug Gilbert's sg3 ... */
> 	scsi_set_resid(cmd, srb->total_xfer_length);
> -	/* This may be interpreted by sb. or not ... */
> -	cmd->SCp.this_residual = srb->total_xfer_length;
> -	cmd->SCp.buffers_residual = 0;
> 	if (debug_enabled(DBG_KG)) {
> 		if (srb->total_xfer_length)
> 			dprintkdbg(DBG_KG, "srb_done: (0x%p) <%02i-%i> "

Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

--
Himanshu Madhani	 Oracle Linux Engineering





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux