Re: [PATCH v2 08/44] 53c700: Stop clearing SCSI pointer fields

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/8/22 18:24, Bart Van Assche wrote:
None of the 53c700 drivers uses the SCSI pointer. Hence remove the code
from 53c700.c that clears two SCSI pointer fields. The 53c700 drivers are:

$ git grep -nHE 'include.*53c700'
drivers/scsi/53c700.c:132:#include "53c700.h"
drivers/scsi/53c700.c:153:#include "53c700_d.h"
drivers/scsi/a4000t.c:22:#include "53c700.h"
drivers/scsi/bvme6000_scsi.c:23:#include "53c700.h"
drivers/scsi/lasi700.c:43:#include "53c700.h"
drivers/scsi/mvme16x_scsi.c:23:#include "53c700.h"
drivers/scsi/sim710.c:29:#include "53c700.h"
drivers/scsi/sni_53c710.c:38:#include "53c700.h"
drivers/scsi/zorro7xx.c:25:#include "53c700.h"

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
---
  drivers/scsi/53c700.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c
index ad4972c0fc53..e1e4f9d10887 100644
--- a/drivers/scsi/53c700.c
+++ b/drivers/scsi/53c700.c
@@ -1791,8 +1791,6 @@ static int NCR_700_queuecommand_lck(struct scsi_cmnd *SCp)
  	slot->cmnd = SCp;
SCp->host_scribble = (unsigned char *)slot;
-	SCp->SCp.ptr = NULL;
-	SCp->SCp.buffer = NULL;
#ifdef NCR_700_DEBUG
  	printk("53c700: scsi%d, command ", SCp->device->host->host_no);

Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke                Kernel Storage Architect
hare@xxxxxxx                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux