Dmitry,
> My only concern is dm_crypt target which operates on bip_iter directly
> with the code copy-pasted from bio_integrity_advance:
>
> static int dm_crypt_integrity_io_alloc(struct dm_crypt_io *io, struct bio *bio)
> {
> struct bio_integrity_payload *bip;
> unsigned int tag_len;
> int ret;
>
> if (!bio_sectors(bio) || !io->cc->on_disk_tag_size)
> return 0;
>
> bip = bio_integrity_alloc(bio, GFP_NOIO, 1);
> if (IS_ERR(bip))
> return PTR_ERR(bip);
>
> tag_len = io->cc->on_disk_tag_size * (bio_sectors(bio) >> io->cc->sector_shift);
>
> bip->bip_iter.bi_size = tag_len;
> bip->bip_iter.bi_sector = io->cc->start + io->sector;
> ^^^
>
> ret = bio_integrity_add_page(bio, virt_to_page(io->integrity_metadata),
> tag_len, offset_in_page(io->integrity_metadata));
> ...
> }
I copied Milan and Mike who are more familiar with the dm-drypt internals.
--
Martin K. Petersen Oracle Linux Engineering
