Re: [PATCH 11/44] aha1542: Remove a set-but-not-used array

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2022-01-28 at 14:18 -0800, Bart Van Assche wrote:
> @@ -240,7 +239,7 @@ static int aha1542_test_port(struct Scsi_Host
> *sh)
>         for (i = 0; i < 4; i++) {
>                 if (!wait_mask(STATUS(sh->io_port), DF, DF, 0, 0))
>                         return 0;
> -               inquiry_result[i] = inb(DATA(sh->io_port));
> +               inb(DATA(sh->io_port));
>         }


Maybe:
		(void)inb(DATA(sh->ip_port));

so it's obvious we don't care about the read data.

Otherwise,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux