(adding checkpatch reviewers Dwaipayan and Lukas) Original thread: https://lore.kernel.org/lkml/20220127151945.1244439-1-trix@xxxxxxxxxx/ On Fri, 2022-01-28 at 07:30 -0800, Tom Rix wrote: > On 1/28/22 12:41 AM, Joe Perches wrote: > > Another option would be to use: > > > > ./scripts/checkpatch.pl -f --fix[-inplace] [--types=<list>] <files> > > > > where types is an optional list of specific things to change > > > > see: > > ./scripts/checkpatch.pl --list-types --verbose > > > > to show the possible types. > > > > Only some of these types can be changed with --fix or --fix-inplace > > > > If using checkpatch to change formatting, it sometimes can be useful > > to run checkpatch --fix multiple times on the same file as a > > checkpatch --fix can create a change than checkpatch will suggest > > should itself be fixed. > > > > Of course another option is to do nothing as many will complain, > > sometimes senselessly, about 'churn'. > > A testsuite for the fixers may help with churn Likely not, as IMO churn is an 'eye of beholder' issue. > Any interest or thought on organization ? Not really. The checkpatch --fix code isn't perfect as it's just regexes. When writing the --fix code, I've always just used the kernel sources and git history to inspect/verify suggested changes. > I can take stab at one. Enjoy.
