On Fri, 2022-01-28 at 14:38 +0200, Julian Wiedmann wrote: > On 25.01.22 18:24, mwilck@xxxxxxxx wrote: > > From: Martin Wilck <mwilck@xxxxxxxx> > > > > If a SCSI device handler module is loaded after some SCSI devices > > have already been probed (e.g. via request_module() by dm- > > multipath), > > the "access_state" and "preferred_path" sysfs attributes remain > > invisible for > > these devices, although the handler is attached and live. The > > reason is > > that the visibility is only checked when the sysfs attribute group > > is > > first created. This results in an inconsistent user experience > > depending > > on the load order of SCSI low-level drivers vs. device handler > > modules. > > > > I suppose you looked at sysfs_update_group(), and it's not a good > fit? I admit I'm afraid of introducing race conditions when I update the visibility of attributes of live SCSI devices. I believe that'd be much harder to get right, and I don't see what's wrong with simply always making the attribute visible (other than a rather minimal user API change, which hardly any user will notice). Martin
