On 1/27/22 22:12, John Garry wrote: > make W=1 complains of an undescribed function pararm: > > drivers/scsi/pm8001/pm80xx_hwi.c:3938: warning: Function parameter or member 'circularQ' not described in 'process_one_iomb' > > Fix it. > > Reported-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx> > Signed-off-by: John Garry <john.garry@xxxxxxxxxx> > --- > drivers/scsi/pm8001/pm80xx_hwi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c > index bbf538fe15b3..ce38a2298e75 100644 > --- a/drivers/scsi/pm8001/pm80xx_hwi.c > +++ b/drivers/scsi/pm8001/pm80xx_hwi.c > @@ -3931,6 +3931,7 @@ static int ssp_coalesced_comp_resp(struct pm8001_hba_info *pm8001_ha, > /** > * process_one_iomb - process one outbound Queue memory block > * @pm8001_ha: our hba card information > + * @circularQ: outbound circular queue Nit: you could remove the CaMeL case here while at it :) > * @piomb: IO message buffer > */ > static void process_one_iomb(struct pm8001_hba_info *pm8001_ha, But anyway, looks good. Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx> -- Damien Le Moal Western Digital Research
