On Mon, Jan 24, 2022 at 02:16:24PM +0100, Christoph Hellwig wrote: > On Sat, Jan 22, 2022 at 07:10:51PM +0800, Ming Lei wrote: > > Add one helper of disk_release_queue for releasing queue data for disk. > > Please explain what "queue data for disk" is, and why this helper is Here it means elevator, blk-cgroup and rq qos, all actually serve FS IOs, maybe it should be changed to FS IOs. > useful. Right now it seems to just move a few things around without a > rationale or explanation of why it is safe. This patch just moves two function calls into the helper, and there doesn't have functional change, so no need rationale and explanation. Thanks, Ming