[Bug 215447] sr_mod scsi_mode_sense() failure -> "scsi-1 drive"

[bugzilla-daemon@xxxxxxxxxxxxxxxxxxx]

https://bugzilla.kernel.org/show_bug.cgi?id=215447

--- Comment #7 from Chris Horler (cshorler@xxxxxxxxxxxxxx) ---
is it risky to implement the fallback mechanism in both directions? is there a
chance of forever retry? (fail 6, fail 10, fail 6, fail 10...)

scsi_lib.c:scsi_mode_sense(): ...

        if (!scsi_status_is_good(result) &&
            driver_byte(result) == DRIVER_SENSE) {
                if (scsi_sense_valid(sshdr)) {
                        if ((sshdr->sense_key == ILLEGAL_REQUEST) &&
                            (sshdr->asc == 0x20) && (sshdr->ascq == 0)) {
                                /* 
                                 * Invalid command operation code
                                 */
                                sdev->use_10_for_ms = !sdev->use_10_for_ms;
                                goto retry;
                        }
                }
        }

I guess I could increase the default retry_count at initialisation and also
decrementing it here.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.