Hi Himanshu, On Sun, 2 Jan 2022, 4:52pm, Himanshu Madhani wrote: > > > > On Dec 23, 2021, at 11:07 PM, Nilesh Javali <njavali@xxxxxxxxxxx> wrote: > > > > From: Arun Easi <aeasi@xxxxxxxxxxx> > > > > 28XX adapters are capable of detecting both T10 PI tag escape values > > as well as IP guard. This was missed due to the adapter type missed > > in the corresponding macros. Fix this by adding support for 28xx in > > those macros. > > > > This patch seems to fix more than just IP guard macros. > Can you please seperate T10 PI fix with other fixes from this patch. > Thanks for the review. You are right. This is actually a mixup of the descriptions. This patch is a bunch of short changes for the 28xx enablement, which somehow was missed sending initially; will send an update. Regards, -Arun