Re: [PATCH 15/16] qla2xxx: Suppress a kernel complaint in qla_create_qpair()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Dec 23, 2021, at 11:07 PM, Nilesh Javali <njavali@xxxxxxxxxxx> wrote:
> 
> From: Saurav Kashyap <skashyap@xxxxxxxxxxx>
> 
> [   12.323788] BUG: using smp_processor_id() in preemptible [00000000] code: systemd-udevd/1020
> [   12.332297] caller is qla2xxx_create_qpair+0x32a/0x5d0 [qla2xxx]
> [   12.338417] CPU: 7 PID: 1020 Comm: systemd-udevd Tainted: G          I      --------- ---  5.14.0-29.el9.x86_64 #1
> [   12.348827] Hardware name: Dell Inc. PowerEdge R610/0F0XJ6, BIOS 6.6.0 05/22/2018
> [   12.356356] Call Trace:
> [   12.358821]  dump_stack_lvl+0x34/0x44
> [   12.362514]  check_preemption_disabled+0xd9/0xe0
> [   12.367164]  qla2xxx_create_qpair+0x32a/0x5d0 [qla2xxx]
> [   12.372481]  qla2x00_probe_one+0xa3a/0x1b80 [qla2xxx]
> [   12.377617]  ? _raw_spin_lock_irqsave+0x19/0x40
> [   12.384284]  local_pci_probe+0x42/0x80
> [   12.390162]  ? pci_match_device+0xd7/0x110
> [   12.396366]  pci_device_probe+0xfd/0x1b0
> [   12.402372]  really_probe+0x1e7/0x3e0
> [   12.408114]  __driver_probe_device+0xfe/0x180
> [   12.414544]  driver_probe_device+0x1e/0x90
> [   12.420685]  __driver_attach+0xc0/0x1c0
> [   12.426536]  ? __device_attach_driver+0xe0/0xe0
> [   12.433061]  ? __device_attach_driver+0xe0/0xe0
> [   12.439538]  bus_for_each_dev+0x78/0xc0
> [   12.445294]  bus_add_driver+0x12b/0x1e0
> [   12.451021]  driver_register+0x8f/0xe0
> [   12.456631]  ? 0xffffffffc07bc000
> [   12.461773]  qla2x00_module_init+0x1be/0x229 [qla2xxx]
> [   12.468776]  do_one_initcall+0x44/0x200
> [   12.474401]  ? load_module+0xad3/0xba0
> [   12.479908]  ? kmem_cache_alloc_trace+0x45/0x410
> [   12.486268]  do_init_module+0x5c/0x280
> [   12.491730]  __do_sys_init_module+0x12e/0x1b0
> [   12.497785]  do_syscall_64+0x3b/0x90
> [   12.503029]  entry_SYSCALL_64_after_hwframe+0x44/0xae
> [   12.509764] RIP: 0033:0x7f554f73ab2e
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Saurav Kashyap <skashyap@xxxxxxxxxxx>
> Signed-off-by: Nilesh Javali <njavali@xxxxxxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
> index 87382477ff85..7e2b629e885f 100644
> --- a/drivers/scsi/qla2xxx/qla_init.c
> +++ b/drivers/scsi/qla2xxx/qla_init.c
> @@ -9412,7 +9412,7 @@ struct qla_qpair *qla2xxx_create_qpair(struct scsi_qla_host *vha, int qos,
> 		qpair->rsp->req = qpair->req;
> 		qpair->rsp->qpair = qpair;
> 		/* init qpair to this cpu. Will adjust at run time. */
> -		qla_cpu_update(qpair, smp_processor_id());
> +		qla_cpu_update(qpair, raw_smp_processor_id());
> 
> 		if (IS_T10_PI_CAPABLE(ha) && ql2xenabledif) {
> 			if (ha->fw_attributes & BIT_4)
> -- 
> 2.23.1
> 

Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

--
Himanshu Madhani	 Oracle Linux Engineering





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux