On Thu, May 31, 2007 at 08:35:13AM -0400, Jeff Garzik wrote: > Cornelia Huck wrote: > >On Thu, 31 May 2007 06:15:57 -0600, > >Matthew Wilcox <matthew@xxxxxx> wrote: > > > >>On Thu, May 31, 2007 at 02:09:22PM +0200, Cornelia Huck wrote: > >>>I split those functions out into a new file. Builds on s390 and i386. > >>Why not just put #ifdef CONFIG_HAS_DMA / #endif around the pair of > >>functions? I don't see the need to add a new Kconfig symbol and a new > >>file for this. > > > >I prefer a new file over #ifdefs in c files. (New dma-dependent stuff > >would also have a place where it could go to.) > > > >But I'll do whatever ends up as consensus :) > > 50 lines isn't much need for a new file. The scsi core shouldn't know anything about dma mappings, so a separate file is a good idea just to keep the separation clean. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
