[-cc Peter Rivera (bouncing)]
On Thu, Dec 16, 2021 at 05:32:51PM -0600, Bjorn Helgaas wrote:
> On Thu, Dec 16, 2021 at 05:30:07PM -0600, Bjorn Helgaas wrote:
> > On Thu, May 20, 2021 at 08:55:42PM +0530, Kashyap Desai wrote:
> > > +static int mpi3mr_suspend(struct pci_dev *pdev, pm_message_t state)
> > > +{
> > > + mpi3mr_cleanup_ioc(mrioc, 1);
> >
> > This looks possibly wrong. mpi3mr_cleanup_ioc() takes a "reason",
> > which looks like it should be MPI3MR_COMPLETE_CLEANUP (0),
> > MPI3MR_REINIT_FAILURE (1), or MPI3MR_SUSPEND (2).
> >
> > This should at least use the enum, and it looks like it should use
> > MPI3MR_SUSPEND instead of passing the MPI3MR_REINIT_FAILURE value.
Sorry for the noise about this part, I see you fixed this later with
0da66348c26f ("scsi: mpi3mr: Set up IRQs in resume path").
