On 11/25/21 11:33 PM, Yanling Song wrote:
+config RAMAXEL_SPRAID
+ tristate "Ramaxel spraid Adapter"
+ depends on PCI && SCSI && BLK_DEV_BSGLIB
+ depends on ARM64 || X86_64
Why is this driver restricted to ARM64 and X86_64 systems? What prevents
compilation of this driver on other CPU architectures?
+ help
+ This driver supports Ramaxel spraid driver.
The help text is too short. Please add one or two sentences about the interface
type of this RAID controller (PCIe?) and also about the storage media supported
by this RAID controller (SAS? SATA? any other?).
+struct spraid_bsg_request {
+ u32 msgcode;
+ u32 control;
+ union {
+ struct spraid_passthru_common_cmd admcmd;
+ struct spraid_ioq_passthru_cmd ioqcmd;
+ };
+};
Definitions like the above are required by user space software that uses the
BSG interface and hence should be moved into a header file under include/uapi/.
See e.g. include/uapi/scsi/scsi_bsg_ufs.h.
Thanks,
Bart.
